Repository navigation
Conversation
…s and approach paths The arm's configuration on mantis.arm.configuration; moves in the deck frame through the unit's stage transform, each move across guarded by a rise to the traverse height; speeds in mm/s at the nozzle; park and recovery along each zone's route; move_to_waste and move_to_wash from wherever the head stands; request_pose for every joint in the deck frame. Co-Authored-By: Claude Opus 5.5 <[email protected]>
BioCam
force-pushed
the
mantis-v1-04-arm-moves
branch
from
November 13, 2026 20:24
f98893f to
e6234df
Compare
…nd LC3 carousel V3Arm takes the arm's configuration and the approved v3_arm_configuration, reads through request_joint_state and request_pose, and refuses every move after the bring-up until a v3 has run it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Each link's mesh, in mm and in the link's own frame, is declared in manifest.json and attached by arm_link, as the chip racks and the Z column are. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Board 11 gets a second attempt before its silence makes a unit a v3, and an arm block with absolute-encoder references refuses the v3 path, so a v4's arms are never seated against their stops. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The v3 arm and pneumatic clamp become private plumbing of Arm and PlateClamp, picked by the generation in listed fork points. The v3 bring-up sends the same bytes; where the arms are is read from a v4's absolute encoders or a v3's homed motor positions, and moves on a v3 stay refused until a v3 has run them. Co-Authored-By: Rick Wierenga <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
…le in the deck frame Route lines, approach paths, zone routes, the post-homing position and the kinematics' positions are MantisArmCoordinate, never a PLR Coordinate; _get_arm_frame_location and _get_deck_frame_location convert between the two over the unrounded float helpers, so what is sent is unchanged. Co-Authored-By: Claude Opus 5.5 <[email protected]>
… in text - Leaving the waste or a wash, the arms go back first with Z held, then Z rises, never both at depth. - Arguments are checked before the head leaves an approach path; Z alone is refused on one. - A queued move that times out or is cancelled is aborted and every motor stopped. - An xy speed or acceleration given alone still ends both arm motors together. - MantisPose and MantisArmConfiguration in docs/api; the notebook's arm cells run in simulation. - The clamp's 'clamping done' means its timer ran out, not that a plate is held. - Messages show mm and degrees with 2 decimals; nothing sent is rounded. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…e queue Python before 3.12 can drop a cancellation that races a reply inside asyncio.wait_for, so the test cancelled as 0/68's reply arrived and the move then timed out on 3.10 and 3.11. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The device refused a queued move whose barely-turning motor got a scaled acceleration of 18.2 device units/s² (error 6). Speeds stay scaled per motor by turn; both motors take the route's acceleration, or the given one as the motor that turns most needs it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…motor-error test The test cut every command's reply timeout to 0.25 s for the one command never answered, so a slow CI runner timed out an answered one (0/17). Co-Authored-By: Claude Opus 5.5 <[email protected]>
Mantis: move the arm in the deck frame, guarded, with zone routes and approach pathsMantis: one arm for v3 and v4, moved in the deck frame, guarded, with zone routes and approach paths
BioCam
marked this pull request as ready for review
November 17, 2026 09:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
The Mantis could bring its arm up and stop it, but not move it. A move has to be given in PyLabRobot's deck frame, where wells are, while the arm is a five-bar linkage calibrated per unit, with a tilted stage. A move across the deck must first clear what stands on it, and from anywhere (any zone, the waste, a wash) the arm needs a safe way back to idle. Main meanwhile gained a separate v3 arm and clamp, so two classes each would have stood side by side.
PR Content/Solution
How a move works:
flowchart TD A["move_to_location(well)"] --> B["well in the deck frame"] B --> C["arm frame: the unit's calibration"] C --> D["two arm angles + Z"] D --> E{"Z low?"} E -- yes --> F["raise Z, read it back"] F --> G["arms across, then Z down"] E -- no --> GWhere the arm can go, and how it gets home:
flowchart TD Z["anywhere on the deck"] -- "park(): the zone's route" --> I(("idle")) I -- "move_to_location()" --> P["wellplate"] I -- "move_to_waste()" --> W["waste"] I -- "move_to_wash()" --> X["wash 1 or 2"] W -- "leave: arms first, then Z" --> I X -- "leave: arms first, then Z" --> IUsage
Every snippet ran top to bottom in simulation on this head.
Features
Armand onePlateClampon v3 and v4, with the same public methods; the generation picks only private plumbing. A v4 reads where it is from its absolute encoders, a v3 homes on its flags; a v3's moves after bring-up raiseNotImplementedErroruntil a v3 has run them. A v4 is never taken for a v3.Coordinates, the unit's own frame isMantisArmCoordinate.MantisPoseandMantisArmConfigurationindocs/api; everything runs onMantis(simulation=True).On the device
A Mantis v4, head clear, no chip:
stop(), recoverysetup()from all six zonesOne defect: with only an xy speed given, a barely-turning motor got a scaled-down acceleration that the device refused; the run stopped safely. Fixed (accelerations are never scaled down) and covered by tests, not yet re-run on the device. Moves on a v3 after bring-up have not run on a v3.
Follow-ups:
move_to_xy_positionandmove_to_locationcan differ by one floating-point bit; nine tests still cut every reply timeout to 0.25 s.🤖 Generated with Claude Code